Re: [PATCH v3 3/4] staging: fbtft: Don't spam logs when probe is deferred
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: 2021-04-29 16:56:13
Also in:
dri-devel, linux-staging, lkml
On Thu, Apr 29, 2021 at 05:42:44PM +0300, Dan Carpenter wrote:
On Wed, Apr 28, 2021 at 04:04:14PM +0300, Andy Shevchenko wrote:
quoted
+ if (IS_ERR(*gpiop)) + dev_err_probe(dev, PTR_ERR(*gpiop), "Failed to request %s GPIO\n", name);This should be a return statement: return dev_err_probe(dev, PTR_ERR(*gpiop), "Failed to request %s GPIO\n", name);
Thanks! Funny that I have trapped to this and my patch that adds __must_check to avoid exactly this situations had been reverted :-( -- With Best Regards, Andy Shevchenko