Re: [PATCH v3 3/4] staging: fbtft: Don't spam logs when probe is deferred
From: Dan Carpenter <hidden>
Date: 2021-04-29 14:43:13
Also in:
dri-devel, linux-staging, lkml
On Wed, Apr 28, 2021 at 04:04:14PM +0300, Andy Shevchenko wrote:
quoted hunk ↗ jump to hunk
@@ -75,20 +75,16 @@ static int fbtft_request_one_gpio(struct fbtft_par *par, struct gpio_desc **gpiop) { struct device *dev = par->info->device; - int ret = 0; *gpiop = devm_gpiod_get_index_optional(dev, name, index, GPIOD_OUT_LOW); - if (IS_ERR(*gpiop)) { - ret = PTR_ERR(*gpiop); - dev_err(dev, - "Failed to request %s GPIO: %d\n", name, ret); - return ret; - } + if (IS_ERR(*gpiop)) + dev_err_probe(dev, PTR_ERR(*gpiop), "Failed to request %s GPIO\n", name);
This should be a return statement: return dev_err_probe(dev, PTR_ERR(*gpiop), "Failed to request %s GPIO\n", name);
+ fbtft_par_dbg(DEBUG_REQUEST_GPIOS, par, "%s: '%s' GPIO\n", __func__, name); - return ret; + return 0; }
regards, dan carpenter