Re: [PATCH v2 02/28] video: fbcon: Fix warnings by using pr_debug() in fbcon

From
Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Date
2020-11-30 01:03:59
Also in
dri-devel
Reply to
Thomas Zimmermann, 2020-11-29
On 2020/11/29 19:03, Thomas Zimmermann wrote:
Am 28.11.20 um 23:40 schrieb Sam Ravnborg:
quoted
Replacing DPRINTK() statements with pr_debug fixes set but not used
warnings.  And moves to a more standard logging setup at the same time.
I guess this was added for quick debugging during development. Anyway, I never liked these kinds of hacks.

Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
But replacing printk(KERN_DEBUG) with pr_debug() prevents __func__ from being printed
when FBCONDEBUG is defined. Is such change what the author of this module expects?
Thread (78 messages) 78 messages, 7 authors, last reply 2020-12-05
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help