Re: [PATCH v2 02/28] video: fbcon: Fix warnings by using pr_debug() in fbcon

[PATCH v2 0/28] drivers/video: W=1 warning fixes · Sam Ravnborg <hidden> · 2020-11-28
[PATCH v2 01/28] video: Fix kernel-doc warnings in of_display_timing + of_videomode · Sam Ravnborg <hidden> · 2020-11-28
Re: [PATCH v2 01/28] video: Fix kernel-doc warnings in of_display_timing + of_videomode · Thomas Zimmermann <tzimmermann@suse.de> · 2020-11-29
Re: [PATCH v2 01/28] video: Fix kernel-doc warnings in of_display_timing + of_videomode · Sam Ravnborg <hidden> · 2020-11-29
Re: [PATCH v2 01/28] video: Fix kernel-doc warnings in of_display_timing + of_videomode · Sam Ravnborg <hidden> · 2020-11-29
[PATCH v2 03/28] video: fbdev: core: Fix kernel-doc warnings in fbmon + fb_notify · Sam Ravnborg <hidden> · 2020-11-28
Re: [PATCH v2 03/28] video: fbdev: core: Fix kernel-doc warnings in fbmon + fb_notify · Thomas Zimmermann <tzimmermann@suse.de> · 2020-11-29
[PATCH v2 04/28] video: fbdev: aty: Delete unused variable in radeon_monitor · Sam Ravnborg <hidden> · 2020-11-28
Re: [PATCH v2 04/28] video: fbdev: aty: Delete unused variable in radeon_monitor · Thomas Zimmermann <tzimmermann@suse.de> · 2020-11-30
[PATCH v2 02/28] video: fbcon: Fix warnings by using pr_debug() in fbcon · Sam Ravnborg <hidden> · 2020-11-28
Re: [PATCH v2 02/28] video: fbcon: Fix warnings by using pr_debug() in fbcon · Thomas Zimmermann <tzimmermann@suse.de> · 2020-11-29
Re: [PATCH v2 02/28] video: fbcon: Fix warnings by using pr_debug() in fbcon · Sam Ravnborg <hidden> · 2020-11-29
Re: [PATCH v2 02/28] video: fbcon: Fix warnings by using pr_debug() in fbcon · Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp> · 2020-11-30
Re: [PATCH v2 02/28] video: fbcon: Fix warnings by using pr_debug() in fbcon · Sam Ravnborg <hidden> · 2020-11-29
Re: [PATCH v2 02/28] video: fbcon: Fix warnings by using pr_debug() in fbcon · Peilin Ye <hidden> · 2020-11-30
Re: [PATCH v2 02/28] video: fbcon: Fix warnings by using pr_debug() in fbcon · Sam Ravnborg <hidden> · 2020-11-30
Re: [PATCH v2 02/28] video: fbcon: Fix warnings by using pr_debug() in fbcon · Peilin Ye <hidden> · 2020-11-30
[PATCH v2 05/28] video: fbdev: aty: Fix set but not used warnings · Sam Ravnborg <hidden> · 2020-11-28
Re: [PATCH v2 05/28] video: fbdev: aty: Fix set but not used warnings · Thomas Zimmermann <tzimmermann@suse.de> · 2020-11-30
[PATCH v2 08/28] video: fbdev: sis: Fix defined but not used warning of SiS_TVDelay · Sam Ravnborg <hidden> · 2020-11-28
Re: [PATCH v2 08/28] video: fbdev: sis: Fix defined but not used warning of SiS_TVDelay · Thomas Zimmermann <tzimmermann@suse.de> · 2020-11-30
Re: [PATCH v2 08/28] video: fbdev: sis: Fix defined but not used warning of SiS_TVDelay · Sam Ravnborg <hidden> · 2020-11-30
Re: [PATCH v2 08/28] video: fbdev: sis: Fix defined but not used warning of SiS_TVDelay · Thomas Zimmermann <tzimmermann@suse.de> · 2020-12-01
[PATCH v2 10/28] video: fbdev: sis: Fix set but not used warnings in sis_main · Sam Ravnborg <hidden> · 2020-11-28
Re: [PATCH v2 10/28] video: fbdev: sis: Fix set but not used warnings in sis_main · Thomas Zimmermann <tzimmermann@suse.de> · 2020-11-30
[PATCH v2 06/28] video: fbdev: aty: Fix set but not used warnings in mach64_ct · Sam Ravnborg <hidden> · 2020-11-28
Re: [PATCH v2 06/28] video: fbdev: aty: Fix set but not used warnings in mach64_ct · Thomas Zimmermann <tzimmermann@suse.de> · 2020-11-30
[PATCH v2 11/28] video: fbdev: via: Fix set but not used warning for mode_crt_table · Sam Ravnborg <hidden> · 2020-11-28
Re: [PATCH v2 11/28] video: fbdev: via: Fix set but not used warning for mode_crt_table · Thomas Zimmermann <tzimmermann@suse.de> · 2020-11-30
[PATCH v2 15/28] video: fbdev: neofb: Fix set but not used warning for CursorMem · Sam Ravnborg <hidden> · 2020-11-28
Re: [PATCH v2 15/28] video: fbdev: neofb: Fix set but not used warning for CursorMem · Thomas Zimmermann <tzimmermann@suse.de> · 2020-11-30
[PATCH v2 16/28] video: fbdev: hgafb: Fix kernel-doc warnings · Sam Ravnborg <hidden> · 2020-11-28
Re: [PATCH v2 16/28] video: fbdev: hgafb: Fix kernel-doc warnings · Randy Dunlap <hidden> · 2020-11-30
[PATCH v2 14/28] video: fbdev: pm2fb: Fix kernel-doc warnings · Sam Ravnborg <hidden> · 2020-11-28
Re: [PATCH v2 14/28] video: fbdev: pm2fb: Fix kernel-doc warnings · Thomas Zimmermann <tzimmermann@suse.de> · 2020-11-30
[PATCH v2 17/28] video: fbdev: tgafb: Fix kernel-doc and set but not used warnings · Sam Ravnborg <hidden> · 2020-11-28
Re: [PATCH v2 17/28] video: fbdev: tgafb: Fix kernel-doc and set but not used warnings · Thomas Zimmermann <tzimmermann@suse.de> · 2020-11-30
[PATCH v2 12/28] video: fbdev: tdfx: Fix set but not used warning in att_outb() · Sam Ravnborg <hidden> · 2020-11-28
Re: [PATCH v2 12/28] video: fbdev: tdfx: Fix set but not used warning in att_outb() · Thomas Zimmermann <tzimmermann@suse.de> · 2020-11-30
[PATCH v2 18/28] video: fbdev: mx3fb: Fix kernel-doc, set but not used and string warnings · Sam Ravnborg <hidden> · 2020-11-28
Re: [PATCH v2 18/28] video: fbdev: mx3fb: Fix kernel-doc, set but not used and string warnings · Thomas Zimmermann <tzimmermann@suse.de> · 2020-11-30
[PATCH v2 09/28] video: fbdev: sis: Fix set but not used warnings in init.c · Sam Ravnborg <hidden> · 2020-11-28
Re: [PATCH v2 09/28] video: fbdev: sis: Fix set but not used warnings in init.c · Thomas Zimmermann <tzimmermann@suse.de> · 2020-11-30
[PATCH v2 13/28] video: fbdev: riva: Fix kernel-doc and set but not used warnings · Sam Ravnborg <hidden> · 2020-11-28
Re: [PATCH v2 13/28] video: fbdev: riva: Fix kernel-doc and set but not used warnings · Thomas Zimmermann <tzimmermann@suse.de> · 2020-11-30
Re: [PATCH v2 13/28] video: fbdev: riva: Fix kernel-doc and set but not used warnings · Sam Ravnborg <hidden> · 2020-11-30
Re: [PATCH v2 13/28] video: fbdev: riva: Fix kernel-doc and set but not used warnings · Lee Jones <hidden> · 2020-12-01
Re: [PATCH v2 13/28] video: fbdev: riva: Fix kernel-doc and set but not used warnings · Sam Ravnborg <hidden> · 2020-12-01
Re: [PATCH v2 13/28] video: fbdev: riva: Fix kernel-doc and set but not used warnings · Lee Jones <hidden> · 2020-12-01
Re: [PATCH v2 13/28] video: fbdev: riva: Fix kernel-doc and set but not used warnings · Daniel Vetter <hidden> · 2020-12-01
Re: [PATCH v2 13/28] video: fbdev: riva: Fix kernel-doc and set but not used warnings · Lee Jones <hidden> · 2020-12-01
[PATCH v2 20/28] video: fbdev: nvidia: Fix set but not used warnings · Sam Ravnborg <hidden> · 2020-11-28
Re: [PATCH v2 20/28] video: fbdev: nvidia: Fix set but not used warnings · Thomas Zimmermann <tzimmermann@suse.de> · 2020-11-30
[PATCH v2 22/28] video: fbdev: omapfb: Fix set but not used warnings in dsi · Sam Ravnborg <hidden> · 2020-11-28
Re: [PATCH v2 22/28] video: fbdev: omapfb: Fix set but not used warnings in dsi · Thomas Zimmermann <tzimmermann@suse.de> · 2020-12-01
[PATCH v2 23/28] video: fbdev: omapfb: Fix set but not used warnings in hdmi*_core · Sam Ravnborg <hidden> · 2020-11-28
Re: [PATCH v2 23/28] video: fbdev: omapfb: Fix set but not used warnings in hdmi*_core · Thomas Zimmermann <tzimmermann@suse.de> · 2020-12-01
Re: [PATCH v2 23/28] video: fbdev: omapfb: Fix set but not used warnings in hdmi*_core · Sam Ravnborg <hidden> · 2020-12-05
[PATCH v2 27/28] video: fbdev: cirrusfb: Fix kernel-doc and set but not used warnings · Sam Ravnborg <hidden> · 2020-11-28
Re: [PATCH v2 27/28] video: fbdev: cirrusfb: Fix kernel-doc and set but not used warnings · Thomas Zimmermann <tzimmermann@suse.de> · 2020-12-01
Re: [PATCH v2 27/28] video: fbdev: cirrusfb: Fix kernel-doc and set but not used warnings · Sam Ravnborg <hidden> · 2020-12-05
[PATCH v2 21/28] video: fbdev: tmiofb: Fix set but not used warnings · Sam Ravnborg <hidden> · 2020-11-28
Re: [PATCH v2 21/28] video: fbdev: tmiofb: Fix set but not used warnings · Thomas Zimmermann <tzimmermann@suse.de> · 2020-11-30
Re: [PATCH v2 21/28] video: fbdev: tmiofb: Fix set but not used warnings · Sam Ravnborg <hidden> · 2020-11-30
[PATCH v2 19/28] video: fbdev: sstfb: Updated logging to fix set but not used warnings · Sam Ravnborg <hidden> · 2020-11-28
Re: [PATCH v2 19/28] video: fbdev: sstfb: Updated logging to fix set but not used warnings · Thomas Zimmermann <tzimmermann@suse.de> · 2020-11-30
[PATCH v2 07/28] video: fbdev: sis: Fix defined but not used warnings · Sam Ravnborg <hidden> · 2020-11-28
Re: [PATCH v2 07/28] video: fbdev: sis: Fix defined but not used warnings · Thomas Zimmermann <tzimmermann@suse.de> · 2020-11-30
[PATCH v2 26/28] video: fbdev: uvesafb: Fix string related warnings · Sam Ravnborg <hidden> · 2020-11-28
Re: [PATCH v2 26/28] video: fbdev: uvesafb: Fix string related warnings · Thomas Zimmermann <tzimmermann@suse.de> · 2020-12-01
[PATCH v2 24/28] video: fbdev: s3c-fb: Fix kernel-doc and set but not used warnings · Sam Ravnborg <hidden> · 2020-11-28
Re: [PATCH v2 24/28] video: fbdev: s3c-fb: Fix kernel-doc and set but not used warnings · Thomas Zimmermann <tzimmermann@suse.de> · 2020-12-01
[PATCH v2 25/28] video: fbdev: uvesafb: Fix set but not used warning · Sam Ravnborg <hidden> · 2020-11-28
Re: [PATCH v2 25/28] video: fbdev: uvesafb: Fix set but not used warning · Thomas Zimmermann <tzimmermann@suse.de> · 2020-12-01
[PATCH v2 28/28] video: fbdev: s1d13xxxfb: Fix kernel-doc and set but not used warnings · Sam Ravnborg <hidden> · 2020-11-28
Re: [PATCH v2 28/28] video: fbdev: s1d13xxxfb: Fix kernel-doc and set but not used warnings · Thomas Zimmermann <tzimmermann@suse.de> · 2020-11-29
Re: [PATCH v2 28/28] video: fbdev: s1d13xxxfb: Fix kernel-doc and set but not used warnings · Sam Ravnborg <hidden> · 2020-11-29
Re: [PATCH v2 28/28] video: fbdev: s1d13xxxfb: Fix kernel-doc and set but not used warnings · Thomas Zimmermann <tzimmermann@suse.de> · 2020-12-01

From: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Date: 2020-11-30 01:03:59
Also in: dri-devel

On 2020/11/29 19:03, Thomas Zimmermann wrote:

Am 28.11.20 um 23:40 schrieb Sam Ravnborg:

quoted

Replacing DPRINTK() statements with pr_debug fixes set but not used
warnings.  And moves to a more standard logging setup at the same time.

I guess this was added for quick debugging during development. Anyway, I never liked these kinds of hacks.

Acked-by: Thomas Zimmermann <tzimmermann@suse.de>

But replacing printk(KERN_DEBUG) with pr_debug() prevents __func__ from being printed
when FBCONDEBUG is defined. Is such change what the author of this module expects?

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help