Re: [PATCH v2 02/28] video: fbcon: Fix warnings by using pr_debug() in fbcon

From
Sam Ravnborg <hidden>
Date
2020-11-29 21:45:24
Also in
dri-devel
Reply to
Thomas Zimmermann, 2020-11-29
On Sun, Nov 29, 2020 at 11:03:25AM +0100, Thomas Zimmermann wrote:

Am 28.11.20 um 23:40 schrieb Sam Ravnborg:
quoted
Replacing DPRINTK() statements with pr_debug fixes set but not used
warnings.  And moves to a more standard logging setup at the same time.

v2:
   - Fix indent (Joe)

Signed-off-by: Sam Ravnborg <redacted>
Cc: Joe Perches <joe@perches.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Daniel Vetter <redacted>
Cc: Bartlomiej Zolnierkiewicz <redacted>
Cc: Sam Ravnborg <redacted>
Cc: Jiri Slaby <jirislaby@kernel.org>
Cc: Peilin Ye <redacted>
Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: George Kennedy <redacted>
Cc: Nathan Chancellor <redacted>
Cc: Peter Rosin <redacted>
---
  drivers/video/fbdev/core/fbcon.c | 25 ++++++++-----------------
  1 file changed, 8 insertions(+), 17 deletions(-)
diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c
index bf61598bf1c3..44a5cd2f54cc 100644
--- a/drivers/video/fbdev/core/fbcon.c
+++ b/drivers/video/fbdev/core/fbcon.c
@@ -56,8 +56,6 @@
   *  more details.
   */
-#undef FBCONDEBUG
-
I guess this was added for quick debugging during development. Anyway, I
never liked these kinds of hacks.

Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
Thanks, applied to drm-misc-next.

	Sam
Thread (78 messages) 78 messages, 7 authors, last reply 2020-12-05
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help