Re: [PATCH v1 02/28] video: fbcon: Use pr_debug() in fbcon
From: Joe Perches <joe@perches.com>
Date: 2020-11-27 21:16:55
Also in:
dri-devel
On Fri, 2020-11-27 at 20:57 +0100, Sam Ravnborg wrote:
Replacing DPRINTK() statements with pr_debug fixes W=1 warnings. And moves to a more standard logging setup at the same time.
[]
quoted hunk ↗ jump to hunk
diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c
[]
quoted hunk ↗ jump to hunk
@@ -1015,9 +1007,9 @@ static const char *fbcon_startup(void)rows /= vc->vc_font.height; vc_resize(vc, cols, rows); - DPRINTK("mode: %s\n", info->fix.id); - DPRINTK("visual: %d\n", info->fix.visual); - DPRINTK("res: %dx%d-%d\n", info->var.xres, + pr_debug("mode: %s\n", info->fix.id); + pr_debug("visual: %d\n", info->fix.visual); + pr_debug("res: %dx%d-%d\n", info->var.xres, info->var.yres, info->var.bits_per_pixel);
It'd be nicer to reindent the subsequent lines too.
quoted hunk ↗ jump to hunk
@@ -3299,7 +3291,7 @@ static void fbcon_exit(void)if (info->queue.func) pending = cancel_work_sync(&info->queue); - DPRINTK("fbcon: %s pending work\n", (pending ? "canceled" : + pr_debug("fbcon: %s pending work\n", (pending ? "canceled" : "no"));
perhaps:
pr_debug("fbcon: %s pending work\n", pending ? "canceled" : "no");