Thread (34 messages) 34 messages, 4 authors, 2020-11-28

[PATCH v1 12/28] video: fbdev: tdfx: Fix W=1 warnings

From: Sam Ravnborg <hidden>
Date: 2020-11-27 19:59:12
Also in: dri-devel
Subsystem: framebuffer layer, the rest · Maintainers: Helge Deller, Linus Torvalds

Fix W=1 warning about unused assignment.
Fix by dropping the local variable.

Signed-off-by: Sam Ravnborg <redacted>
Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: Sam Ravnborg <redacted>
Cc: Jani Nikula <redacted>
Cc: Daniel Vetter <redacted>
Cc: Arnd Bergmann <arnd@arndb.de>
---
 drivers/video/fbdev/tdfxfb.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/video/fbdev/tdfxfb.c b/drivers/video/fbdev/tdfxfb.c
index f056d80f6359..67e37a62b07c 100644
--- a/drivers/video/fbdev/tdfxfb.c
+++ b/drivers/video/fbdev/tdfxfb.c
@@ -206,9 +206,7 @@ static inline u8 crt_inb(struct tdfx_par *par, u32 idx)
 
 static inline void att_outb(struct tdfx_par *par, u32 idx, u8 val)
 {
-	unsigned char tmp;
-
-	tmp = vga_inb(par, IS1_R);
+	vga_inb(par, IS1_R);
 	vga_outb(par, ATT_IW, idx);
 	vga_outb(par, ATT_IW, val);
 }
-- 
2.27.0
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help