Re: [PATCH 1/2] console: Remove dummy con_font_op() callback implementations
From: Daniel Vetter <hidden>
Date: 2020-11-10 12:49:54
Also in:
dri-devel, linux-usb, lkml
On Fri, Nov 06, 2020 at 11:50:58AM +0100, Greg Kroah-Hartman wrote:
On Sat, Oct 31, 2020 at 03:24:41AM -0400, Peilin Ye wrote:quoted
`struct console_font` is a UAPI structure, thus ideally should not be used for kernel internal abstraction. Remove some dummy .con_font_set, .con_font_default and .con_font_copy `struct consw` callback implementations, to make it cleaner. Patch "fbcon: Prevent global-out-of-bounds read in fbcon_copy_font()" depends on this patch, so Cc: stable. Cc: stable@vger.kernel.org Suggested-by: Daniel Vetter <redacted> Signed-off-by: Peilin Ye <redacted> --- Context: https://lore.kernel.org/lkml/CAKMK7uFY2zv0adjKJ_ORVFT7Zzwn075MaU0rEU7_FuqENLR=UA@mail.gmail.com/ (local) drivers/usb/misc/sisusbvga/sisusb_con.c | 21 --------------------- drivers/video/console/dummycon.c | 20 -------------------- 2 files changed, 41 deletions(-)Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Peilin, can you pls resend this together with all the other pending patches from you? I think that's better than me trying to cherry-pick the bits we decided to keep from random places. Greg, ok if I just pull these in through drm-misc-next? It's a pretty bad hairball anyway and that avoids the tree coordination issues. Only thing that might get in the way is the vt font_copy removal, but that's in -rc3 so easy to backmerge. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch