Re: [PATCH 1/2] video: fbdev: amifb: remove dead APUS support
flat view
From: Emil Velikov <hidden>
Date: 2020-06-15 20:38:55
Also in:
dri-devel, linux-m68k, lkml
Hi Bartlomiej, On Tue, 2 Jun 2020 at 11:37, Bartlomiej Zolnierkiewicz [off-list ref] wrote:
On 5/14/20 10:21 PM, Geert Uytterhoeven wrote:quoted
These #ifdefs are relics from APUS (Amiga Power-Up System), which added a PPC board. APUS support was killed off a long time ago, when arch/ppc/ was still king, but these #ifdefs were missed, because they didn't test for CONFIG_APUS.Reported-by: Al Viro <viro@zeniv.linux.org.uk> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org> Signed-off-by: Bartlomiej Zolnierkiewicz <redacted> --- drivers/video/fbdev/amifb.c | 63 -------------------------------------------- 1 file changed, 63 deletions(-)
A quick look through my checkout (drm-misc/next aka 5.8 ish), shows multiple other places which check for the define. And a single place where it's being set - the Makefile below. Should those be addressed as well? Or perhaps they are and I've got an old tree. HTH Emil $ git grep -c __mc68000__ arch/m68k/Makefile:1 drivers/block/floppy.c:2 drivers/ide/ide-probe.c:2 drivers/input/misc/hp_sdc_rtc.c:1 drivers/input/serio/hp_sdc.c:3 drivers/input/serio/hp_sdc_mlc.c:1 drivers/net/ethernet/i825xx/82596.c:8 drivers/tty/vt/keyboard.c:1 drivers/video/fbdev/amifb.c:11 include/linux/a.out.h:1 include/linux/hp_sdc.h:1 include/uapi/linux/a.out.h:1 lib/fonts/fonts.c:2 lib/mpi/longlong.h:1