[PATCH 2/2] video: fbdev: amifb: add FIXMEs about {put,get}_user() failures
flat view
STALE2285d
From: Bartlomiej Zolnierkiewicz <hidden>
Date: 2020-06-02 10:38:23
Also in:
dri-devel, linux-m68k, lkml
Since we lack the hardware (or proper emulator setup) for testing needed changes add FIXMEs to document the issues (so at least they are not forgotten). Cc: Al Viro <viro@zeniv.linux.org.uk> Cc: Geert Uytterhoeven <geert@linux-m68k.org> Signed-off-by: Bartlomiej Zolnierkiewicz <redacted> --- drivers/video/fbdev/amifb.c | 2 ++ 1 file changed, 2 insertions(+) Index: b/drivers/video/fbdev/amifb.c =================================--- a/drivers/video/fbdev/amifb.c
+++ b/drivers/video/fbdev/amifb.c@@ -1866,6 +1866,7 @@ static int ami_get_var_cursorinfo(struct "clrb %0 ; swap %1 ; lslw #1,%1 ; roxlb #1,%0 ; " "swap %1 ; lslw #1,%1 ; roxlb #1,%0" : "=d" (color), "=d" (datawords) : "1" (datawords)); + /* FIXME: check the return value + test the change */ put_user(color, data++); } if (bits > 0) {
@@ -1923,6 +1924,7 @@ static int ami_set_var_cursorinfo(struct bits = 16; words = delta; datawords = 0; for (width = (short)var->width - 1; width >= 0; width--) { unsigned long tdata = 0; + /* FIXME: check the return value + test the change */ get_user(tdata, data); data++; asm volatile (