Thread (40 messages) 40 messages, 2 authors, 2020-02-10

RE: [PATCH v3 10/17] drm/i915: Include DP VSC SDP in the crtc state dump

From: Shankar, Uma <hidden>
Date: 2020-02-05 16:46:29
Also in: dri-devel, intel-gfx

-----Original Message-----
From: dri-devel <redacted> On Behalf Of Gwan-
gyeong Mun
Sent: Tuesday, February 4, 2020 4:50 AM
To: intel-gfx@lists.freedesktop.org
Cc: linux-fbdev@vger.kernel.org; dri-devel@lists.freedesktop.org
Subject: [PATCH v3 10/17] drm/i915: Include DP VSC SDP in the crtc state dump

Dump out the DP VSC SDP in the normal crtc state dump

v3: Replace a structure name to drm_dp_vsc_sdp from intel_dp_vsc_sdp
    Use drm core's DP VSC SDP logging function
Looks good to me.
Reviewed-by: Uma Shankar <redacted>
quoted hunk ↗ jump to hunk
Signed-off-by: Gwan-gyeong Mun <redacted>
---
 drivers/gpu/drm/i915/display/intel_display.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)
diff --git a/drivers/gpu/drm/i915/display/intel_display.c
b/drivers/gpu/drm/i915/display/intel_display.c
index 593c63f51210..4f187fd330e8 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -12878,6 +12878,16 @@ intel_dump_infoframe(struct drm_i915_private
*dev_priv,
 	hdmi_infoframe_log(KERN_DEBUG, dev_priv->drm.dev, frame);  }

+static void
+intel_dump_dp_vsc_sdp(struct drm_i915_private *dev_priv,
+		      const struct drm_dp_vsc_sdp *vsc) {
+	if (!drm_debug_enabled(DRM_UT_KMS))
+		return;
+
+	drm_dp_vsc_sdp_log(KERN_DEBUG, dev_priv->drm.dev, vsc); }
+
 #define OUTPUT_TYPE(x) [INTEL_OUTPUT_ ## x] = #x

 static const char * const output_type_str[] = { @@ -13036,6 +13046,9 @@ static
void intel_dump_pipe_config(const struct intel_crtc_state *pipe_config,
 	if (pipe_config->infoframes.enable &
 	    intel_hdmi_infoframe_enable(HDMI_PACKET_TYPE_GAMUT_METADATA))
 		intel_dump_infoframe(dev_priv, &pipe_config->infoframes.drm);
+	if (pipe_config->infoframes.enable &
+	    intel_hdmi_infoframe_enable(DP_SDP_VSC))
+		intel_dump_dp_vsc_sdp(dev_priv, &pipe_config->infoframes.vsc);

 	drm_dbg_kms(&dev_priv->drm, "requested mode:\n");
 	drm_mode_debug_printmodeline(&pipe_config->hw.mode);
--
2.24.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help