Thread (40 messages) 40 messages, 2 authors, 2020-02-10

RE: [PATCH v3 03/17] drm/i915/dp: Add compute routine for DP HDR Metadata Infoframe SDP

From: Shankar, Uma <hidden>
Date: 2020-02-05 15:11:13
Also in: dri-devel, intel-gfx

-----Original Message-----
From: dri-devel <redacted> On Behalf Of Gwan-
gyeong Mun
Sent: Tuesday, February 4, 2020 4:50 AM
To: intel-gfx@lists.freedesktop.org
Cc: linux-fbdev@vger.kernel.org; dri-devel@lists.freedesktop.org
Subject: [PATCH v3 03/17] drm/i915/dp: Add compute routine for DP HDR Metadata
Infoframe SDP

It stores computed dp hdr metadata infoframe sdp to infoframes.drm of crtc state.
It referenced intel_hdmi_compute_drm_infoframe().

While computing, we'll also fill out the inforames.enable bitmask appropriately.
Typo in infoframes

With the above fixed, this is
Reviewed-by: Uma Shankar <redacted>
quoted hunk ↗ jump to hunk
v2: Wrap a long line.

Signed-off-by: Gwan-gyeong Mun <redacted>
---
 drivers/gpu/drm/i915/display/intel_dp.c | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c
b/drivers/gpu/drm/i915/display/intel_dp.c
index 2bdc43c80e03..b265b5c599f2 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -2463,6 +2463,27 @@ static void intel_dp_compute_vsc_sdp(struct intel_dp
*intel_dp,
 					 &crtc_state->infoframes.vsc);
 }

+static void
+intel_dp_compute_hdr_metadata_infoframe_sdp(struct intel_crtc_state
*crtc_state,
+					    const struct drm_connector_state
*conn_state) {
+	int ret;
+	struct hdmi_drm_infoframe *drm_infoframe > +&crtc_state->infoframes.drm.drm;
+
+	if (!conn_state->hdr_output_metadata)
+		return;
+
+	ret = drm_hdmi_infoframe_set_hdr_metadata(drm_infoframe, conn_state);
+
+	if (ret) {
+		DRM_DEBUG_KMS("couldn't set HDR metadata in infoframe\n");
+		return;
+	}
+
+	crtc_state->infoframes.enable |> +
	intel_hdmi_infoframe_enable(HDMI_PACKET_TYPE_GAMUT_METADATA);
+}
+
 int
 intel_dp_compute_config(struct intel_encoder *encoder,
 			struct intel_crtc_state *pipe_config, @@ -2569,6 +2590,7
@@ intel_dp_compute_config(struct intel_encoder *encoder,

 	intel_psr_compute_config(intel_dp, pipe_config);
 	intel_dp_compute_vsc_sdp(intel_dp, pipe_config, conn_state);
+	intel_dp_compute_hdr_metadata_infoframe_sdp(pipe_config, conn_state);

 	return 0;
 }
--
2.24.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help