Thread (32 messages) 32 messages, 5 authors, 2019-09-02

Re: [PATCH v3 2/4] backlight: Expose brightness curve type through sysfs

From: Daniel Thompson <hidden>
Date: 2019-08-29 14:09:12
Also in: dri-devel, linux-pwm, lkml

On Tue, Aug 27, 2019 at 10:44:59AM +0100, Lee Jones wrote:
[...]
quoted
quoted
IIUC the conclusion is that there is no need for a string attribute
because we only need to distinguish between 'perceptual' and
'non-perceptual'. If that is correct, do you have any preference for
the attribute name ('perceptual_scale', 'perceptual', ...)?
More a summary than a conclusion! There is a reason I have left a bit or
space for others to comment on this over the last month (and a bit).

To be clear my Reviewed-by: means that I believe that the kernel is better
with "non-linear/linear/unknown" than without it and that I am comfortable
the API isn't likely to be a millstone for us.

Lee, Jingoo: Either of you care to offer $0.02
No, not really.  Happy to leave it to your good judgement.
In that case... the patch has my reviewed-by and although the concerns
raised in the associated threads have merit I don't think they are
enough to stop the patch.

Please merge.


Daniel.
-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help