Thread (7 messages) flat view 7 messages, 3 authors, 2019-03-20

Re: [RESEND][PATCH 2/2] staging: sm750fb: trivial Camel Case removal for setDisplayControl().

From: Dan Carpenter <hidden>
Date: 2019-03-20 12:36:49
Also in: lkml

On Mon, Mar 04, 2019 at 12:55:32AM +0800, Yifeng Li wrote:
Rename the function setDisplayControl() to set_display_control().
This fixes the following checkpatch.pl warning:

    CHECK: Avoid CamelCase: <setDisplayControl>

Suggested-by: Jin Chen <redacted>
Signed-off-by: Jin Chen <redacted>
[tomli@tomli.me: resent as trivial patch, reworded the commit message]
Signed-off-by: Yifeng Li <redacted>
---
Apparently Greg already applied this earlier...  I don't know why the
original patch didn't reach me.  I'm on the devel@driverdev.osuosl.org
list.

Did Jin Chen write this?  If so why does it have a Suggested-by tag for
him?  If not then you should have preserved the authorship credit by
using the From: header in the first line on the commit message...

Anyway, it doesn't matter but hopefully this helps for next time.

regards,
dan carpenter
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help