Re: [PATCH] backlight: adp8860: Mark expected switch fall-through
From: Daniel Thompson <hidden>
Date: 2018-07-10 09:00:14
Also in:
dri-devel, lkml
On Mon, Jul 09, 2018 at 04:51:56PM -0500, Gustavo A. R. Silva wrote:
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustavo A. R. Silva <redacted>
Having checked the datasheets... Reviewed-by: Daniel Thompson <redacted>
quoted hunk ↗ jump to hunk
--- drivers/video/backlight/adp8860_bl.c | 1 + 1 file changed, 1 insertion(+)diff --git a/drivers/video/backlight/adp8860_bl.c b/drivers/video/backlight/adp8860_bl.c index 16119bd..f1dc41c 100644 --- a/drivers/video/backlight/adp8860_bl.c +++ b/drivers/video/backlight/adp8860_bl.c@@ -690,6 +690,7 @@ static int adp8860_probe(struct i2c_client *client, switch (ADP8860_MANID(reg_val)) { case ADP8863_MANUFID: data->gdwn_dis = !!pdata->gdwn_dis; + /* fall through */ case ADP8860_MANUFID: data->en_ambl_sens = !!pdata->en_ambl_sens; break;-- 2.7.4