Re: [PATCH] backlight: adp8860: Mark expected switch fall-through

From
Michael Hennerich <michael.hennerich@analog.com>
Date
2018-07-10 06:42:54
Also in
dri-devel, lkml
Reply to
Gustavo A. R. Silva, 2018-07-09
On 09.07.2018 23:51, Gustavo A. R. Silva wrote:
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Signed-off-by: Gustavo A. R. Silva <redacted>
Acked-by: Michael Hennerich <michael.hennerich@analog.com>
quoted hunk ↗ jump to hunk
---
  drivers/video/backlight/adp8860_bl.c | 1 +
  1 file changed, 1 insertion(+)
diff --git a/drivers/video/backlight/adp8860_bl.c b/drivers/video/backlight/adp8860_bl.c
index 16119bd..f1dc41c 100644
--- a/drivers/video/backlight/adp8860_bl.c
+++ b/drivers/video/backlight/adp8860_bl.c
@@ -690,6 +690,7 @@ static int adp8860_probe(struct i2c_client *client,
  	switch (ADP8860_MANID(reg_val)) {
  	case ADP8863_MANUFID:
  		data->gdwn_dis = !!pdata->gdwn_dis;
+		/* fall through */
  	case ADP8860_MANUFID:
  		data->en_ambl_sens = !!pdata->en_ambl_sens;
  		break;

-- 
Greetings,
Michael

--
Analog Devices GmbH      Otl-Aicher Strasse 60-64      80807 München
Sitz der Gesellschaft München, Registergericht München HRB 40368,
Geschäftsführer: Peter Kolberg, Ali Raza Husain, Eileen Wynne
Thread (5 messages) 5 messages, 4 authors, last reply 2018-07-13
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help