On Fri, Mar 16, 2018 at 09:50:21AM +0100, Geert Uytterhoeven wrote:

Hi Dmitry,

On Thu, Mar 15, 2018 at 11:42 PM, Dmitry Torokhov
[off-list ref] wrote:

quoted

Instead of backlight legacy platform data, let's switch to using device
properties and GPIO lookup tables.

Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

Thanks for your patch!

quoted

--- a/arch/sh/boards/mach-ecovec24/setup.c
+++ b/arch/sh/boards/mach-ecovec24/setup.c

quoted

@@ -367,17 +368,21 @@ static struct platform_device lcdc_device = {
        },
 };

-static struct gpio_backlight_platform_data gpio_backlight_data = {
-       .gpio = GPIO_PTR1,
-       .def_value = 1,
-       .name = "backlight",
+static struct gpiod_lookup_table gpio_backlight_gpios_table = {

gpio_backlight_gpios_table is unused?

There was supposed to be gpiod_add_lookup_table() that I lost as I was
reshuffling and reshuffling the patches.

quoted

+       .dev_id = "gpio-backlight.0",
+       .table = {
+               GPIO_LOOKUP_IDX("sh7724_pfc", GPIO_PTR1, NULL, 0, GPIO_ACTIVE_HIGH);
+               { }
+       },
+};
+
+static struct property_entry gpio_backlight_properties[] = {

const

OK.

quoted

+       PROPERTY_ENTRY_BOOL("default-on"),
+       { }
 };

 static struct platform_device gpio_backlight_device = {
        .name = "gpio-backlight",
-       .dev = {
-               .platform_data = &gpio_backlight_data,
-       },
 };

 /* CEU0 */

@@ -1436,6 +1441,8 @@ static int __init arch_setup(void)
                return error;

        if (use_backlight) {
+               device_add_properties(&gpio_backlight_device.dev,
+                                     gpio_backlight_properties);
                error = platform_device_add(&gpio_backlight_device);
                if (error)
                        pr_warn("%s: failed to register backlight: %d\n",

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

-- 
Dmitry