Re: [RESEND PATCH v5 2/5] dt-bindings: pwm-backlight: add PWM delay proprieties.
From: Lee Jones <hidden>
Date: 2018-02-19 10:39:42
Also in:
linux-pwm, linux-rockchip, lkml
On Mon, 19 Feb 2018, Heiko Stuebner wrote:
Am Montag, 19. Februar 2018, 10:22:47 CET schrieb Lee Jones:quoted
On Fri, 16 Feb 2018, Enric Balletbo i Serra wrote:quoted
Hardware needs a delay between setting an initial (non-zero) PWM and enabling the backlight using GPIO. The post-pwm-on-delay-ms specifies this delay in milli seconds. Hardware also needs a delay between disabing the backlight using GPIO and setting PWM value to 0. The pwm-off-delay-ms is this delay in milli seconds. Signed-off-by: Enric Balletbo i Serra <redacted> Acked-by: Pavel Machek <redacted> --- Based on the original Huang Lin [off-list ref] work. Changes since v4: - Rebase on top of mainline. Changes since v3: - Replace us for ms. - Add Acked-by: Pavel Machek [off-list ref] Changes since v2: - Use separate properties (Rob Herring) Changes since v1: - As suggested by Daniel Thompson - Do not assume power-on delay and power-off delay will be the same Documentation/devicetree/bindings/leds/backlight/pwm-backlight.txt | 6 ++++++ 1 file changed, 6 insertions(+)Looks like this still needs an Ack. Also, you didn't supply a 0th (cover-letter) patch, so I have no idea of patch history or your future intentions. Are there build-time dependencies between them or can each patch be merged via their respective trees without the fear of merge/build failure?When looking at the patches, there do not seem to be any build-time dependencies between the patch 1-3 (backlight) and 4+5 devicetree, so after Rob hopefully has time to look at the binding change, I'd suspect you take the code changes and I'll take the dts changes.
Works for me. -- Lee Jones Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog