Re: [PATCH v2 1/3] Kconfig : Remove HAS_IOMEM dependency for Graphics support
From: Christian Borntraeger <hidden>
Date: 2018-02-15 09:40:29
Also in:
dri-devel, linux-s390, linux-um, lkml
Subsystem:
console subsystem, framebuffer layer, the rest · Maintainers:
Greg Kroah-Hartman, Helge Deller, Linus Torvalds
On 02/08/2018 02:11 PM, Bartlomiej Zolnierkiewicz wrote:
Hi, [ dri-devel ML & arch/[score,um] Maintainers added to Cc: ] On Friday, February 02, 2018 08:59:57 AM Christian Borntraeger wrote:quoted
On 02/01/2018 07:41 PM, Farhan Ali wrote:quoted
The 'commit e25df1205f37 ("[S390] Kconfig: menus with depends on HAS_IOMEM.")' added the HAS_IOMEM dependecy for "Graphics support". This disabled the "Graphics support" menu for S390. But if we enable VT layer for S390, we would also need to enable the dummy console. So let's remove the HAS_IOMEM dependency. Move this dependency to Opencores framebuffer driver which would fail to build with CONFIG_HAS_IOMEM disabled: ERROR: "devm_ioremap_resource" [drivers/video/fbdev/ocfb.ko] undefined!"Graphics support" menu covers other things (i.e. DRM), I assume that they were also checked to not break due to this change? Moreover it seems that after this change "Graphics support" menu will be also enabled (besides s390) for score, tile and um architectures, I assume that this is okay?
Turns out that patch fails to build with. So what about the following approach instead:
diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
index 3c20af999893..5ae512fe52ed 100644
--- a/drivers/video/Kconfig
+++ b/drivers/video/Kconfig@@ -47,3 +47,28 @@ endif endmenu + +config DUMMY_CONSOLE + bool + depends on VGA_CONSOLE!=y || SGI_NEWPORT_CONSOLE!=y + default y + +config DUMMY_CONSOLE_COLUMNS + int "Initial number of console screen columns" + depends on DUMMY_CONSOLE && !ARM + default 160 if PARISC + default 80 + help + On PA-RISC, the default value is 160, which should fit a 1280x1024 + monitor. + Select 80 if you use a 640x480 resolution by default. + +config DUMMY_CONSOLE_ROWS + int "Initial number of console screen rows" + depends on DUMMY_CONSOLE && !ARM + default 64 if PARISC + default 25 + help + On PA-RISC, the default value is 64, which should fit a 1280x1024 + monitor. + Select 25 if you use a 640x480 resolution by default.
diff --git a/drivers/video/console/Kconfig b/drivers/video/console/Kconfig
index 7f1f1fbcef9e..97ae3c349666 100644
--- a/drivers/video/console/Kconfig
+++ b/drivers/video/console/Kconfig@@ -91,31 +91,6 @@ config SGI_NEWPORT_CONSOLE Say Y here if you want the console on the Newport aka XL graphics card of your Indy. Most people say Y here. -config DUMMY_CONSOLE - bool - depends on VGA_CONSOLE!=y || SGI_NEWPORT_CONSOLE!=y - default y - -config DUMMY_CONSOLE_COLUMNS - int "Initial number of console screen columns" - depends on DUMMY_CONSOLE && !ARM - default 160 if PARISC - default 80 - help - On PA-RISC, the default value is 160, which should fit a 1280x1024 - monitor. - Select 80 if you use a 640x480 resolution by default. - -config DUMMY_CONSOLE_ROWS - int "Initial number of console screen rows" - depends on DUMMY_CONSOLE && !ARM - default 64 if PARISC - default 25 - help - On PA-RISC, the default value is 64, which should fit a 1280x1024 - monitor. - Select 25 if you use a 640x480 resolution by default. - config FRAMEBUFFER_CONSOLE bool "Framebuffer Console support" depends on FB && !UML