Thread (20 messages) 20 messages, 5 authors, 2018-02-19

Re: [PATCH v2 1/3] Kconfig : Remove HAS_IOMEM dependency for Graphics support

From: Christian Borntraeger <hidden>
Date: 2018-02-08 15:30:32
Also in: dri-devel, linux-s390, linux-um, lkml


On 02/08/2018 02:11 PM, Bartlomiej Zolnierkiewicz wrote:
Hi,

[ dri-devel ML & arch/[score,um] Maintainers added to Cc: ]

On Friday, February 02, 2018 08:59:57 AM Christian Borntraeger wrote:
quoted
On 02/01/2018 07:41 PM, Farhan Ali wrote:
quoted
The 'commit e25df1205f37 ("[S390] Kconfig: menus with depends on HAS_IOMEM.")'
added the HAS_IOMEM dependecy for "Graphics support". This disabled the
"Graphics support" menu for S390. But if we enable VT layer for S390,
we would also need to enable the dummy console. So let's remove the
HAS_IOMEM dependency.

Move this dependency to Opencores framebuffer driver which would fail to build
with CONFIG_HAS_IOMEM disabled:

ERROR: "devm_ioremap_resource" [drivers/video/fbdev/ocfb.ko] undefined!
"Graphics support" menu covers other things (i.e. DRM), I assume that
they were also checked to not break due to this change?

Moreover it seems that after this change "Graphics support" menu will
be also enabled (besides s390) for score, tile and um architectures,
I assume that this is okay?
I can add this patch to my next tree (after merge window) and check for
any errors from all the build bots.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help