Hi,

On Thu, Nov 30, 2017 at 07:24:30AM -0800, Tony Lindgren wrote:

* H. Nikolaus Schaller [off-list ref] [171128 18:35]:

quoted

Hi,

quoted

Am 28.11.2017 um 17:18 schrieb Tony Lindgren [off-list ref]:

* H. Nikolaus Schaller [off-list ref] [171128 16:17]:

quoted

Hi Tony,

quoted

Am 28.11.2017 um 17:04 schrieb Tony Lindgren [off-list ref]:

* H. Nikolaus Schaller [off-list ref] [171128 15:52]:

quoted

We can remove the unnecessary "omapdss," prefix because
the omapdrm driver takes care of it when matching with
the driver table.

So is this needed as a fix or is this another clean-up?

So is this is really needed as a fix?

Hm. How do you differentiate between "fix" and "cleanup"?
Maybe it is more a wording than a content issue...

For me it is a "fix" because it is semantically wrong to have
a prefix where it is not needed. And "fixing" it changes the
compiler output by 8 bytes.

How about let's call it a "typo fix" then? :)

Well, it is not really a typo.

Well what if the stable people pick it into earlier stable series
based on the word fix in the subject? That has happened before.

I suggest you update the dts patches to use wording like
"update compatible to use new naming" or something similar.

Patch 4/4 is a Fix and should be applied to stable trees. "omapdss,"
prefix was never supposed to be in the DTS files, is not supposed to
be in there now and will break some time in the future.

Explanation: The early init of omapdss adds the prefix at runtime,
so that the binding can use generic properties and the kernel can
use omapdss specific drivers until the generic ones can be used.

-- Sebastian