Re: [PATCH v3 4/4] DTS: Pandora: fix panel compatibility string

From
Tony Lindgren <tony@atomide.com>
Date
2017-11-30 15:24:37
Also in
dri-devel, linux-arm-kernel, linux-devicetree, linux-omap, lkml
* H. Nikolaus Schaller [off-list ref] [171128 18:35]:
Hi,
quoted
Am 28.11.2017 um 17:18 schrieb Tony Lindgren [off-list ref]:

* H. Nikolaus Schaller [off-list ref] [171128 16:17]:
quoted
Hi Tony,
quoted
Am 28.11.2017 um 17:04 schrieb Tony Lindgren [off-list ref]:

* H. Nikolaus Schaller [off-list ref] [171128 15:52]:
quoted
We can remove the unnecessary "omapdss," prefix because
the omapdrm driver takes care of it when matching with
the driver table.
So is this needed as a fix or is this another clean-up?

So is this is really needed as a fix?
Hm. How do you differentiate between "fix" and "cleanup"?
Maybe it is more a wording than a content issue...

For me it is a "fix" because it is semantically wrong to have
a prefix where it is not needed. And "fixing" it changes the
compiler output by 8 bytes.
How about let's call it a "typo fix" then? :)
Well, it is not really a typo.
Well what if the stable people pick it into earlier stable series
based on the word fix in the subject? That has happened before.

I suggest you update the dts patches to use wording like
"update compatible to use new naming" or something similar.

Regards,

Tony
Thread (7 messages) 7 messages, 4 authors, last reply 2017-12-11
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help