Thread (12 messages) 12 messages, 4 authors, 2017-11-09

Re: [PATCH 6/8] video: fbdev: au1200fb: Remove some dead code

From: Dan Carpenter <hidden>
Date: 2017-10-17 11:34:18
Also in: dri-devel, kernel-janitors, lkml

On Mon, Oct 16, 2017 at 09:04:52PM +0200, Christophe JAILLET wrote:
quoted hunk ↗ jump to hunk
There is no need to shut gcc up. It should not complain.
Axe 'fbdev', it is never used in this function.

Signed-off-by: Christophe JAILLET <redacted>
---
 drivers/video/fbdev/au1200fb.c | 6 ------
 1 file changed, 6 deletions(-)
diff --git a/drivers/video/fbdev/au1200fb.c b/drivers/video/fbdev/au1200fb.c
index e531543bc707..970ce761ff89 100644
--- a/drivers/video/fbdev/au1200fb.c
+++ b/drivers/video/fbdev/au1200fb.c
@@ -1667,10 +1667,6 @@ static int au1200fb_drv_probe(struct platform_device *dev)
 	printk(DRIVER_NAME ": Panel %d %s\n", panel_index, panel->name);
 	printk(DRIVER_NAME ": Win %d %s\n", window_index, win->name);
 
-	/* shut gcc up */
-	ret = 0;
Heh...  It looks like they were deliberately silencing the warning about
the bug you fixed in patch 2/8.  :P

regards,
dan carpenter
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help