Thread (12 messages) 12 messages, 4 authors, 2017-11-09

Lifecycle

  1. Posted Christophe JAILLET <christophe.jaillet@wanadoo.fr>

[PATCH 4/8] video: fbdev: au1200fb: Fix error handling path

From: Christophe JAILLET <hidden>
Date: 2017-10-16 19:07:48
Also in: dri-devel, kernel-janitors, lkml
Subsystem: framebuffer layer, the rest · Maintainers: Helge Deller, Linus Torvalds

'au1200fb_drv_probe()' can not fail after a succesful call to
'request_irq()'. So there is no point to call 'free_irq()' in the error
handling path.

Moreover, the hard coded AU1200_LCD_INT looks boggus since commit
1630d85a8312 ("au1200fb: fix hardcoded IRQ")

So, remove it.

Signed-off-by: Christophe JAILLET <redacted>
---
 drivers/video/fbdev/au1200fb.c | 2 --
 1 file changed, 2 deletions(-)
diff --git a/drivers/video/fbdev/au1200fb.c b/drivers/video/fbdev/au1200fb.c
index cf54168d44dc..0d8ed0ef9183 100644
--- a/drivers/video/fbdev/au1200fb.c
+++ b/drivers/video/fbdev/au1200fb.c
@@ -1766,8 +1766,6 @@ static int au1200fb_drv_probe(struct platform_device *dev)
 			fb_dealloc_cmap(&fbi->cmap);
 		kfree(fbi->pseudo_palette);
 	}
-	if (plane = 0)
-		free_irq(AU1200_LCD_INT, (void*)dev);
 	return ret;
 }
 
-- 
2.11.0
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help