Thread (30 messages) 30 messages, 2 authors, 2017-08-01

[PATCH 20/28] video: fbdev: sunxvr500: constify pci_device_id.

From: Arvind Yadav <hidden>
Date: 2017-07-20 17:43:16
Also in: lkml
Subsystem: framebuffer layer, the rest · Maintainers: Helge Deller, Linus Torvalds

pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.

File size before:
   text	   data	    bss	    dec	    hex	filename
    170	    488	      0	    658	    292	drivers/video/fbdev/sunxvr500.o

File size After adding 'const':
   text	   data	    bss	    dec	    hex	filename
    394	    264	      0	    658	    292	drivers/video/fbdev/sunxvr500.o

Signed-off-by: Arvind Yadav <redacted>
---
 drivers/video/fbdev/sunxvr500.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/sunxvr500.c b/drivers/video/fbdev/sunxvr500.c
index dc0d886..bc59593 100644
--- a/drivers/video/fbdev/sunxvr500.c
+++ b/drivers/video/fbdev/sunxvr500.c
@@ -393,7 +393,7 @@ static int e3d_pci_register(struct pci_dev *pdev,
 	return err;
 }
 
-static struct pci_device_id e3d_pci_table[] = {
+static const struct pci_device_id e3d_pci_table[] = {
 	{	PCI_DEVICE(PCI_VENDOR_ID_3DLABS, 0x7a0),	},
 	{	PCI_DEVICE(0x1091, 0x7a0),			},
 	{	PCI_DEVICE(PCI_VENDOR_ID_3DLABS, 0x7a2),	},
-- 
2.7.4
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help