Thread (30 messages) 30 messages, 2 authors, 2017-08-01
STALE3221d

[PATCH 13/28] video: fbdev: i810: constify pci_device_id.

From: Arvind Yadav <hidden>
Date: 2017-07-20 17:40:52
Also in: lkml
Subsystem: framebuffer layer, intel 810/815 framebuffer driver, the rest · Maintainers: Helge Deller, Antonino Daplas, Linus Torvalds

pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.

File size before:
   text	   data	    bss	    dec	    hex	filename
  13132	    520	     56	  13708	   358c	video/fbdev/i810/i810_main.o

File size After adding 'const':
   text	   data	    bss	    dec	    hex	filename
  13356	    296	     56	  13708	   358c	video/fbdev/i810/i810_main.o

Signed-off-by: Arvind Yadav <redacted>
---
 drivers/video/fbdev/i810/i810_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/i810/i810_main.c b/drivers/video/fbdev/i810/i810_main.c
index 2488baa..f0a758a 100644
--- a/drivers/video/fbdev/i810/i810_main.c
+++ b/drivers/video/fbdev/i810/i810_main.c
@@ -107,7 +107,7 @@ static const char * const i810_pci_list[] = {
 	"Intel(R) 815 (Internal Graphics with AGP) Framebuffer Device"
 };
 
-static struct pci_device_id i810fb_pci_tbl[] = {
+static const struct pci_device_id i810fb_pci_tbl[] = {
 	{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82810_IG1,
 	  PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0 },
 	{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82810_IG3,
-- 
2.7.4
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help