Re: [PATCH v10 3/3] backlight arcxcnn add support for ArcticSand devices
From: Lee Jones <hidden>
Date: 2017-05-08 14:31:13
Also in:
linux-devicetree, lkml
On Fri, 05 May 2017, Olimpiu Dejeu wrote:
quoted
quoted
backlight: Add support for Arctic Sand LED backlight driver chipsquoted
This should be the subject line of the patch.quoted
Out of interest, how are you submitting your patches?quoted
If you're not already, you should be using:> `git format-patch ...` > `git send-email ...`quoted
quoted
This driver provides support for the Arctic Sand arc2c0608 chip, and provides a framework to support future devices.quoted
'\n' here.quoted
quoted
Reviewed-by: Daniel Thompson <redacted> Signed-off-by: Olimpiu Dejeu <redacted>quoted
Biggest point however is that this patch is already in Mainline.The only reason for this set of patches is based on the request from Rob Herring for vendor name change from 'arc' to 'arctic'. Not sure how to proceed, please advise.
You need to only re-send the patches which have not been accepted already. So fix the comments I gave you on the vendor name patch and only re-send that one.
quoted
quoted
--- v9 => v10: - Per Rob Herring's request changed vendor-prefix to arctic v8 => v9: - Addressing kbuild test robot WARNING: PTR_ERR_OR_ZERO can be used v7 => v8: - Version updated to match other patch in set. No other changes. v6 => v7: - Addressing issues brought up by Daniel Thompson v5 => v6: - Addressing issues brought up by Daniel Thompson v4 => v5: - Code style changes per Joe Perches and Jingoo Han v3 => v4: - Code style changes per Joe Perches and Jingoo Han v2 => v3: - Renamed variables to comply with conventions on naming - Corrected device name in arcxcnn.h v1 => v2: - Removed "magic numbers" to initialize registers - Cleaned up device tree bindings - Fixed code style to address comments and pass "checkpatch" - Removed unneeded debug and testing code drivers/video/backlight/Kconfig | 7 + drivers/video/backlight/Makefile | 1 + drivers/video/backlight/arcxcnn_bl.c | 419 +++++++++++++++++++++++++++++++++++ 3 files changed, 427 insertions(+) create mode 100644 drivers/video/backlight/arcxcnn_bl.c
-- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog