Re: [Outreachy kernel] [PATCH 2/5] staging: rtl8192u: Remove unnecessary else after return
From: Julia Lawall <hidden>
Date: 2017-02-27 21:27:59
Also in:
lkml
On Mon, 27 Feb 2017, simran singhal wrote:
quoted hunk ↗ jump to hunk
This patch fixes the checkpatch warning that else is not generally useful after a break or return. This was done using Coccinelle: @@ expression e2; statement s1; @@ if(e2) { ... return ...; } -else s1 Signed-off-by: simran singhal <redacted> --- drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c index 2453413..4d6c928 100644 --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c@@ -374,8 +374,7 @@ static int ieee80211_tkip_encrypt(struct sk_buff *skb, int hdr_len, void *priv) if (!tcb_desc->bHwSec) return ret; - else - return 0; + return 0;
In contrast to another patch I commented on, it seems likely that here 0 means success. Converting 0 to false when that is what it means (ie not here) makes the code more understandable. julia