Thread (26 messages) 26 messages, 3 authors, 2017-03-01

Re: [PATCH 5/5] staging: gdm724x: Remove unnecessary else after return

From: SIMRAN SINGHAL <hidden>
Date: 2017-02-27 20:45:20
Also in: lkml

On Tue, Feb 28, 2017 at 1:11 AM, Joe Perches [off-list ref] wrote:
On Mon, 2017-02-27 at 23:44 +0530, simran singhal wrote:
quoted
This patch fixes the checkpatch warning that else is not generally
useful after a break or return.
quoted
This was done using Coccinelle:
@@
expression e2;
statement s1;
@@
if(e2) { ... return ...; }
-else
         s1
[]
quoted
diff --git a/drivers/staging/gdm724x/gdm_endian.c b/drivers/staging/gdm724x/gdm_endian.c
[]
quoted
@@ -26,30 +26,26 @@ __dev16 gdm_cpu_to_dev16(struct gdm_endian *ed, u16 x)
 {
      if (ed->dev_ed = ENDIANNESS_LITTLE)
              return (__force __dev16)cpu_to_le16(x);
-     else
-             return (__force __dev16)cpu_to_be16(x);
+     return (__force __dev16)cpu_to_be16(x);
again, not a checkpatch message for any of the
suggested modified hunks.
So, I have to change commit message.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help