Thread (49 messages) 49 messages, 7 authors, 2017-02-03

Re: [PATCH v9 4/4] console: Make persistent scrollback a boot parameter

From: Manuel Schölling <hidden>
Date: 2017-02-03 16:06:11
Also in: lkml

Hi Paul,

On Thu, 2017-02-02 at 15:07 -0500, Paul Gortmaker wrote:
On Tue, Jan 10, 2017 at 4:28 PM, Manuel Schölling
[off-list ref] wrote:
quoted
The impact of the persistent scrollback feature on the code size is
rather small, so the config option is removed. The feature stays
disabled by default and can be enabled by using the boot command
line
parameter 'vgacon.scrollback_persistent=1' or by setting
VGACON_SOFT_SCROLLBACK_PERSISTENT_ENABLE_BY_DEFAULT=y.

Signed-off-by: Manuel Schölling <redacted>
Suggested-by: Bartlomiej Zolnierkiewicz <redacted>
---
[...]
quoted
+module_param_named(scrollback_persistent, scrollback_persistent,
bool, 0000);
+MODULE_PARM_DESC(scrollback_persistent, "Enable persistent
scrollback for all vga consoles");
Since this hasn't got widespread deployment yet and  only exists
in Greg's tree, can we please fix the above to use setup_param or
similar, since there is nothing modular about this code at all.
Not sure what you mean here.
If this is not the right may to declare it I'd be more than happy to
change this. But I could not find any function/macro named setup_param
[1].
It would be great if you could give me a hint what function to use
here!

Have a great weekend!

Manuel

[1] http://lxr.free-electrons.com/ident?i=setup_param
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help