On Fri, Jan 13, 2017 at 09:00:34PM +0100, Manuel Schölling wrote:

On Tue, 2017-01-10 at 23:58 +0100, Adam Borowski wrote:

quoted

On Tue, Jan 10, 2017 at 10:28:38PM +0100, Manuel Schölling wrote:

quoted

The impact of the persistent scrollback feature on the code size is
rather small, so the config option is removed. The feature stays
disabled by default and can be enabled by using the boot command
line
parameter 'vgacon.scrollback_persistent=1' or by setting
VGACON_SOFT_SCROLLBACK_PERSISTENT_ENABLE_BY_DEFAULT=y.

Signed-off-by: Manuel Schölling <redacted>
Suggested-by: Bartlomiej Zolnierkiewicz <redacted>
+module_param_named(scrollback_persistent, scrollback_persistent,
bool, 0000);
+MODULE_PARM_DESC(scrollback_persistent, "Enable persistent
scrollback for all vga consoles");

A command-line knob settable by the end-user is something more
persistent
than a config option.  As you're going to extend this code beyond
vgacon in
the near future, perhaps it'd be better to have a shared setting for
all
console drivers?

According to the guys at #kernelnewbies on IRC everybody hates new
command line options.

That was me, you can use my name here :)

I'd rather stick to the module parameter for now and maybe introduce a 
new cmd line option later, once this feature has been implemented in
several console drivers.

Yes, that should be fine.

thanks,

greg k-h