Re: [PATCH v5 15/46] pwm: introduce the pwm_state concept
From: Thierry Reding <hidden>
Date: 2016-04-12 11:49:17
Also in:
dri-devel, intel-gfx, linux-arm-kernel, linux-clk, linux-input, linux-leds, linux-pwm, linux-rockchip, linux-samsung-soc, lkml
On Wed, Mar 30, 2016 at 10:03:38PM +0200, Boris Brezillon wrote:
quoted hunk ↗ jump to hunk
The PWM state, represented by its period, duty_cycle and polarity, is currently directly stored in the PWM device. Declare a pwm_state structure embedding those field so that we can later use this struct to atomically update all the PWM parameters at once. All pwm_get_xxx() helpers are now implemented as wrappers around pwm_get_state(). Signed-off-by: Boris Brezillon <redacted> --- drivers/pwm/core.c | 8 ++++---- include/linux/pwm.h | 54 +++++++++++++++++++++++++++++++++++++++++------------ 2 files changed, 46 insertions(+), 16 deletions(-)diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c index 6433059..f3f91e7 100644 --- a/drivers/pwm/core.c +++ b/drivers/pwm/core.c@@ -268,7 +268,7 @@ int pwmchip_add_with_polarity(struct pwm_chip *chip, pwm->chip = chip; pwm->pwm = chip->base + i; pwm->hwpwm = i; - pwm->polarity = polarity; + pwm->state.polarity = polarity;
Would this not more correctly be assigned to pwm->args.polarity? After all this is setting up the "initial" state, much like DT or the lookup tables would for duty cycle and period. Thierry
Attachments
- signature.asc [application/pgp-signature] 819 bytes