Thread (11 messages) 11 messages, 2 authors, 2015-11-06

Re: [PATCH v2] pwm-backlight: fix the panel power sequence

flat view

From: Philipp Zabel <p.zabel@pengutronix.de>
Date: 2015-11-03 11:08:56
Also in: linux-arm-kernel, linux-mediatek, linux-pwm, lkml

Hi YH,

Am Dienstag, den 03.11.2015, 16:11 +0800 schrieb YH Huang:
quoted
The reasoning is that devices where there is no phandle link pointing to
the backlight (for example from a simple-panel node), we should keep the
current default behaviour (enable during probe).
I have a little problem for the current default behaviour.
Should we enable during probe?
Here I mean enabling the backlight (at the end of the probe function),
not enabling the GPIO already when requesting it.
Before this patch ( http://patchwork.ozlabs.org/patch/324690/ ),
we disable "enable-gpio" in the probe function.
While before this patch the GPIO would be initialized in the disabled
state, the call to backlight_update_status at the end of the probe
function would still enable the backlight afterwards.

regards
Philipp
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help