Thread (11 messages) 11 messages, 2 authors, 2015-11-06

Re: [PATCH v2] pwm-backlight: fix the panel power sequence

From: Philipp Zabel <p.zabel@pengutronix.de>
Date: 2015-10-29 15:41:10
Also in: linux-arm-kernel, linux-mediatek, linux-pwm, lkml

Hi YH,

Am Donnerstag, den 22.10.2015, 23:12 +0800 schrieb YH Huang:
In the case of the panel disabled by the bootloader,
your patch still has the following code and always enables the backlight
in the probe function.
pb->enable_gpio = devm_gpiod_get_optional(&pdev->dev, "enable",
-						  GPIOD_OUT_HIGH);
You are right.
What do you think if I remove these two lines in my patch?
if (pb->enable_gpio)
	gpiod_direction_output(pb->enable_gpio, 0);
That won't work if the gpio is still configured as input. How about I
add the GPIOD_ASIS change to my patch you remove that and the above from
yours?

best regards
Philipp
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help