Re: [RFC] fbdev/riva:change to use generice function to implement reverse_order()

On 20/08/15 14:30, yalin wang wrote:

quoted

On Aug 20, 2015, at 19:02, Tomi Valkeinen [off-list ref] wrote:


On 10/08/15 13:12, yalin wang wrote:

quoted

This change to use swab32(bitrev32()) to implement reverse_order()
function, have better performance on some platforms.

Which platforms? Presuming you tested this, roughly how much better
performance? If you didn't, how do you know it's faster?

i investigate on arm64 platforms:

Ok. So is any arm64 platform actually using these devices? If these
devices are mostly used by 32bit x86 platforms, optimizing them for
arm64 doesn't make any sense.

Possibly the patches are still good for x86 also, but that needs to be
proven.

 Tomi