Thread (31 messages) 31 messages, 3 authors, 2015-06-30

Re: [PATCH v3 11/19] staging: sm750fb: consistent spacing around operators

From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Date: 2015-06-26 04:05:59
Also in: lkml

On Thu, Jun 25, 2015 at 09:26:00AM -0700, Juston Li wrote:
On Thu, Jun 25, 2015 at 4:56 AM, Sudip Mukherjee
[off-list ref] wrote:
quoted
On Wed, Jun 24, 2015 at 09:25:12AM -0700, Juston Li wrote:
<snip>
quoted
2) Considering that you are giving consitent space around operators, then
        i think you have missed few operators like '|','&',':' in this
        patch.
These were the only instances the checkpatch.pl error came up. This patch
only fixes even spacing around a specific operator. Other operators either
have even or no spacing around them with PATCH 11/19 fixing any operators
with spacing around required. This leaves operators that checkpatch deems
spacing as optional which I left as a separate issue to be addressed of making
optional spacing of operators consistent with each other.
Usually I use the checkpatch which is in linux-next. That will be the
latest version. If you compare, last commit on checkpatch of staging
tree was on April 16th, where as last commit in linux-next is on
June 19th. And if you use this checkpatch you will see these warnings
also. :)

regards
sudip
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help