Thread (31 messages) 31 messages, 3 authors, 2015-06-30

Re: [PATCH v3 11/19] staging: sm750fb: consistent spacing around operators

From: Juston Li <hidden>
Date: 2015-06-25 16:26:06
Also in: lkml

On Thu, Jun 25, 2015 at 4:56 AM, Sudip Mukherjee
[off-list ref] wrote:
On Wed, Jun 24, 2015 at 09:25:12AM -0700, Juston Li wrote:
quoted
fixes checkpatch.pl error:
ERROR: need consistent spacing around ''
little bit confused.
1) Your subject says consistent space around operators but here it says
        around ''
The specific checkpatch.pl error was different for each error, the quotes
were suppose to contain the specific operator but I left it out so that there
would be one generic error message. The quotes left behind were confusing,
sorry.
2) Considering that you are giving consitent space around operators, then
        i think you have missed few operators like '|','&',':' in this
        patch.
These were the only instances the checkpatch.pl error came up. This patch
only fixes even spacing around a specific operator. Other operators either
have even or no spacing around them with PATCH 11/19 fixing any operators
with spacing around required. This leaves operators that checkpatch deems
spacing as optional which I left as a separate issue to be addressed of making
optional spacing of operators consistent with each other.

Thanks
Juston
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help