Thread (3 messages) 3 messages, 2 authors, 2015-06-23

Re: [PATCH 6/8] Staging: sm750fb: ddk750_sii164.c: Place braces on previous lines

From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Date: 2015-06-20 07:24:20
Also in: lkml

On Fri, Jun 19, 2015 at 12:48:19PM -0700, Isaac Assegai wrote:
quoted hunk
Place braces on previous lines in ddk750_sii164.c to
rectify the following checkpatch errors:
ERROR: that open brace { should be on the previous line

Signed-off-by: Isaac Assegai <redacted>
---
 drivers/staging/sm750fb/ddk750_sii164.c | 16 +++++-----------
 1 file changed, 5 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_sii164.c b/drivers/staging/sm750fb/ddk750_sii164.c
index 7f58fbe..64d4291 100644
--- a/drivers/staging/sm750fb/ddk750_sii164.c
+++ b/drivers/staging/sm750fb/ddk750_sii164.c
@@ -136,8 +136,7 @@ long sii164InitChip(
 #endif
 
 	/* Check if SII164 Chip exists */
-	if ((sii164GetVendorID() = SII164_VENDOR_ID) && (sii164GetDeviceID() = SII164_DEVICE_ID))
-	{
+	if ((sii164GetVendorID() = SII164_VENDOR_ID) && (sii164GetDeviceID() = SII164_DEVICE_ID) {
												^^^^
you have not build tested it :(
In function ‘sii164InitChip’:
error: expected ‘)’ before ‘{’ token

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help