Re: [PATCH 6/8] Staging: sm750fb: ddk750_sii164.c: Place braces on previous lines

On Fri, Jun 19, 2015 at 12:48:19PM -0700, Isaac Assegai wrote:

												^^^^
you have not build tested it :(
In function ‘sii164InitChip’:
error: expected ‘)’ before ‘{’ token

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in

On Sat, Jun 20, 2015 at 12:54:02PM +0530, Sudip Mukherjee wrote:

On Fri, Jun 19, 2015 at 12:48:19PM -0700, Isaac Assegai wrote:

quoted

Place braces on previous lines in ddk750_sii164.c to
rectify the following checkpatch errors:
ERROR: that open brace { should be on the previous line

Signed-off-by: Isaac Assegai <redacted>
---
 drivers/staging/sm750fb/ddk750_sii164.c | 16 +++++-----------
 1 file changed, 5 insertions(+), 11 deletions(-)

diff --git a/drivers/staging/sm750fb/ddk750_sii164.c b/drivers/staging/sm750fb/ddk750_sii164.c
index 7f58fbe..64d4291 100644
--- a/drivers/staging/sm750fb/ddk750_sii164.c
+++ b/drivers/staging/sm750fb/ddk750_sii164.c

@@ -136,8 +136,7 @@ long sii164InitChip(
 #endif
 
 	/* Check if SII164 Chip exists */
-	if ((sii164GetVendorID() = SII164_VENDOR_ID) && (sii164GetDeviceID() = SII164_DEVICE_ID))
-	{
+	if ((sii164GetVendorID() = SII164_VENDOR_ID) && (sii164GetDeviceID() = SII164_DEVICE_ID) {

												^^^^
you have not build tested it :(
In function ‘sii164InitChip’:
error: expected ‘)’ before ‘{’ token

I never get Isaac's emails.  I think gmail is still sending them to the
Spam folder?  I searched my spam folder and don't see them though...

regards,
dan carpenter

On Tue, Jun 23, 2015 at 11:55:48AM +0300, Dan Carpenter wrote:

On Sat, Jun 20, 2015 at 12:54:02PM +0530, Sudip Mukherjee wrote:

quoted

On Fri, Jun 19, 2015 at 12:48:19PM -0700, Isaac Assegai wrote:

I never get Isaac's emails.  I think gmail is still sending them to the
Spam folder?  I searched my spam folder and don't see them though...

maybe you need to create filters. I have filters and sometimes for some
mails I will get "this was not sent to spam because of a filter you created"

regards
sudip