Re: [PATCH] video: ARM CLCD: Added support for FBIO_WAITFORVSYNC

On 15-03-02 03:29 PM, Rob Herring wrote:

On Wed, Feb 25, 2015 at 3:01 PM, Arun Ramamurthy
[off-list ref] wrote:

quoted

Added ioctl and interrupt handler functions to support FBIO_WAITFORVSYNC
Also corrected documentation to make interrupts and interrupt-names
optional as they are not required properties.

Reviewed-by: Ray Jui <rjui@broadcom.com>
Reviewed-by: Scott Branden <sbranden@broadcom.com>
Signed-off-by: Arun Ramamurthy <redacted>0
---
  .../devicetree/bindings/video/arm,pl11x.txt        | 11 +--

Please split bindings to separate patches.

Rob, I looked at the history of patches to this driver and all them 
included changes to the documentation in the same patch so I followed a 
similar model. I assumed that a separate patch was only required when 
the documentation was being added from scratch and not when modifying a 
few lines. Is this not the case?

quoted

  drivers/video/fbdev/amba-clcd.c                    | 82 ++++++++++++++++++++++
  include/linux/amba/clcd.h                          |  4 ++
  3 files changed, 89 insertions(+), 8 deletions(-)

diff --git a/Documentation/devicetree/bindings/video/arm,pl11x.txt b/Documentation/devicetree/bindings/video/arm,pl11x.txt
index 2262cdb..7d19024 100644
--- a/Documentation/devicetree/bindings/video/arm,pl11x.txt
+++ b/Documentation/devicetree/bindings/video/arm,pl11x.txt

@@ -10,14 +10,6 @@ Required properties:

  - reg: base address and size of the control registers block

-- interrupt-names: either the single entry "combined" representing a
-       combined interrupt output (CLCDINTR), or the four entries
-       "mbe", "vcomp", "lnbu", "fuf" representing the individual
-       CLCDMBEINTR, CLCDVCOMPINTR, CLCDLNBUINTR, CLCDFUFINTR interrupts
-
-- interrupts: contains an interrupt specifier for each entry in
-       interrupt-names
-
  - clock-names: should contain "clcdclk" and "apb_pclk"

  - clocks: contains phandle and clock specifier pairs for the entries

@@ -54,6 +46,9 @@ Optional properties:
         It can be used to configure a virtual y resolution. It
         must be a value larger than the actual y resolution.

+- interrupts: contains an interrupt specifier for the clcd vcomp interrupt
+        This is required for the driver to handle FBIO_WAITFORVSYNC ioctls.
+

What happened to interrupt-names?

As mentioned before, these changes to the documentation  will be undone 
in V2. Thanks

Rob