Re: [PATCH] video: ARM CLCD: Added support for FBIOPAN_DISPLAY and virtual y resolution
From: Pawel Moll <hidden>
Date: 2015-03-02 16:08:35
Also in:
linux-devicetree, lkml
On Wed, 2015-02-25 at 21:01 +0000, Arun Ramamurthy wrote:
quoted hunk ↗ jump to hunk
Added code to support FBIOPAN_DISPLAY. Also added yres_virtual parameter to device tree to set the virtual y resolution Reviewed-by: Ray Jui <rjui@broadcom.com> Reviewed-by: Scott Branden <sbranden@broadcom.com> Signed-off-by: Arun Ramamurthy <redacted> --- .../devicetree/bindings/video/arm,pl11x.txt | 4 +++ drivers/video/fbdev/amba-clcd.c | 31 +++++++++++++++++++--- 2 files changed, 31 insertions(+), 4 deletions(-)diff --git a/Documentation/devicetree/bindings/video/arm,pl11x.txt b/Documentation/devicetree/bindings/video/arm,pl11x.txt index 14d6f87..2262cdb 100644 --- a/Documentation/devicetree/bindings/video/arm,pl11x.txt +++ b/Documentation/devicetree/bindings/video/arm,pl11x.txt@@ -50,6 +50,10 @@ Optional properties: display mode, data is driven onto the LCD data lines at the programmed edge of CLCP when CLAC is in its active state. +- yres_virtual: Virtual Y resolution, + It can be used to configure a virtual y resolution. It + must be a value larger than the actual y resolution. +
I'm not sure about this... The word "virtual" never works well with device tree nodes defined as "hardware description". I understand what you're doing, but adding this property to the display controller's node doesn't sound right. How does this describe hardware? If anywhere, it's more like a job for the panel node? Pawel