Re: [PATCHv2 1/4] video: fsl-dcfb: Add dcfb framebuffer driver for LS1021A platform
From: Alexander Stein <hidden>
Date: 2014-12-04 09:19:31
Also in:
linux-arm-kernel, lkml
On Wednesday 03 December 2014 17:15:59, Xiubo Li wrote:
+ tnp = of_find_node_by_name(dnp, "display-timings");
+ if (!tnp) {
+ dev_err(dcfb->dev, "failed to find \"display-timings\" node\n");
+ return -ENODEV;
+ goto put_dnp;
+ }
+
+ for (i = 0; i < of_get_child_count(tnp); i++) {
+ struct videomode vm;
+
+ ret = videomode_from_timings(timings, &vm, i);
+ if (ret < 0)
+ goto put_tnp;
+
+ ret = fb_videomode_from_videomode(&vm, &fb_vm);
+ if (ret < 0)
+ goto put_tnp;
+
+ fb_add_videomode(&fb_vm, &info->modelist);
+ }
+
+ ret = of_get_fb_videomode(dnp, &fb_vm, OF_USE_NATIVE_MODE);
+ if (ret)
+ goto put_dnp;Souldn't this be put_tnp like in the loop above?
+ fb_videomode_to_var(&info->var, &fb_vm); + ret = fsl_dcfb_check_var(&info->var, info);
But picking the native mode per default looks nice to be! :) Best regards, Alexander -- Dipl.-Inf. Alexander Stein SYS TEC electronic GmbH Am Windrad 2 08468 Heinsdorfergrund Tel.: 03765 38600-1156 Fax: 03765 38600-4100 Email: alexander.stein@systec-electronic.com Website: www.systec-electronic.com Managing Director: Dipl.-Phys. Siegmar Schmidt Commercial registry: Amtsgericht Chemnitz, HRB 28082