Re: [PATCH 11/15] sound: soc: poodle: make use of new locomo GPIO interface
From: Alexandre Courbot <hidden>
Date: 2014-10-29 03:03:55
Also in:
alsa-devel, linux-arm-kernel, linux-gpio, linux-input, linux-leds, linux-spi
Possibly related (same subject, not in this thread)
- 2014-11-01 · Re: [PATCH 11/15] sound: soc: poodle: make use of new locomo GPIO interface · Alexandre Courbot <hidden>
- 2014-10-31 · Re: [PATCH 11/15] sound: soc: poodle: make use of new locomo GPIO interface · Dmitry Eremin-Solenikov <hidden>
- 2014-10-31 · Re: [PATCH 11/15] sound: soc: poodle: make use of new locomo GPIO interface · Linus Walleij <hidden>
- 2014-10-28 · Re: [PATCH 11/15] sound: soc: poodle: make use of new locomo GPIO interface · Dmitry Eremin-Solenikov <hidden>
- 2014-10-28 · [PATCH 11/15] sound: soc: poodle: make use of new locomo GPIO interface · Dmitry Eremin-Solenikov <hidden>
On Tue, Oct 28, 2014 at 11:58 PM, Mark Brown [off-list ref] wrote:
On Tue, Oct 28, 2014 at 03:02:04AM +0300, Dmitry Eremin-Solenikov wrote:quoted
Since LoCoMo driver has been converted to provide proper gpiolib interface, make poodle ASoC platform driver use gpiolib API.Please use subject lines matching the style for the subsystem.quoted
+ ret = gpio_request_array(poodle_gpios, ARRAY_SIZE(poodle_gpios)); + if (ret) { + dev_err(&pdev->dev, "gpio_request_array() failed: %d\n", + ret); + return ret; + }I sense a need for devm_gpio_request_array() here. Otherwise this looks fine - ideally it'd move to gpiod but moving to gpiolib is a clear win so no need to block on this.
I wish Dmitry took the opportunity to move this driver to the gpiod API, especially since doing so would be trivial for this driver. Not a critical requirement though, the present patch is already an improvement. But if you want to do that last step, please have a look at Documentation/gpio/consumer.txt and the "Platform Data" section of Documentation/gpio/board.txt.