On Tue, Oct 28, 2014 at 11:58 PM, Mark Brown [off-list ref] wrote:

On Tue, Oct 28, 2014 at 03:02:04AM +0300, Dmitry Eremin-Solenikov wrote:

quoted

Since LoCoMo driver has been converted to provide proper gpiolib
interface, make poodle ASoC platform driver use gpiolib API.

Please use subject lines matching the style for the subsystem.

quoted

+     ret = gpio_request_array(poodle_gpios, ARRAY_SIZE(poodle_gpios));
+     if (ret) {
+             dev_err(&pdev->dev, "gpio_request_array() failed: %d\n",
+                             ret);
+             return ret;
+     }

I sense a need for devm_gpio_request_array() here.  Otherwise this looks
fine - ideally it'd move to gpiod but moving to gpiolib is a clear win
so no need to block on this.

I wish Dmitry took the opportunity to move this driver to the gpiod
API, especially since doing so would be trivial for this driver. Not a
critical requirement though, the present patch is already an
improvement. But if you want to do that last step, please have a look
at Documentation/gpio/consumer.txt and the "Platform Data" section of
Documentation/gpio/board.txt.