Re: [PATCH] video: fbdev: sis: sis_main.c: Cleaning up wrong type in format string
flat view
From: Joe Perches <joe@perches.com>
Date: 2014-07-06 17:46:34
Also in:
lkml
On Sun, 2014-07-06 at 19:36 +0200, Rickard Strandqvist wrote:
Wrong type in printf format string, requires 'unsigned int' but the argument type is 'int'
Perhaps it'd be better to change the type of mydepth to __u16 as that's the type of lfb_depth
quoted hunk ↗ jump to hunk
diff --git a/drivers/video/fbdev/sis/sis_main.c b/drivers/video/fbdev/sis/sis_main.c
[]
quoted hunk ↗ jump to hunk
@@ -237,7 +237,7 @@ static void sisfb_get_vga_mode_from_kernel(void) if(mydepth = 24) mydepth = 32; - sprintf(mymode, "%ux%ux%u", screen_info.lfb_width, + sprintf(mymode, "%ux%ux%d", screen_info.lfb_width, screen_info.lfb_height, mydepth);