[PATCH] video: fbdev: sis: sis_main.c: Cleaning up wrong type in format string

Subsystems: framebuffer layer, sis framebuffer driver, the rest

STALE4475d

2 messages, 2 authors, 2014-07-06 · open the first message on its own page

[PATCH] video: fbdev: sis: sis_main.c: Cleaning up wrong type in format string

From: Rickard Strandqvist <hidden>
Date: 2014-07-06 17:35:17

Wrong type in printf format string, requires 'unsigned int'
but the argument type is 'int'

This was found using a static code analysis program called cppcheck

Signed-off-by: Rickard Strandqvist <redacted>
---
 drivers/video/fbdev/sis/sis_main.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/sis/sis_main.c b/drivers/video/fbdev/sis/sis_main.c
index 22ad028..ab7e5e4 100644
--- a/drivers/video/fbdev/sis/sis_main.c
+++ b/drivers/video/fbdev/sis/sis_main.c
@@ -237,7 +237,7 @@ static void sisfb_get_vga_mode_from_kernel(void)
 
 		if(mydepth = 24) mydepth = 32;
 
-		sprintf(mymode, "%ux%ux%u", screen_info.lfb_width,
+		sprintf(mymode, "%ux%ux%d", screen_info.lfb_width,
 					screen_info.lfb_height,
 					mydepth);
 
-- 
1.7.10.4

Re: [PATCH] video: fbdev: sis: sis_main.c: Cleaning up wrong type in format string

From: Joe Perches <joe@perches.com>
Date: 2014-07-06 17:46:34

On Sun, 2014-07-06 at 19:36 +0200, Rickard Strandqvist wrote:
Wrong type in printf format string, requires 'unsigned int'
but the argument type is 'int'
Perhaps it'd be better to change the type of mydepth
to __u16 as that's the type of lfb_depth
quoted hunk
diff --git a/drivers/video/fbdev/sis/sis_main.c b/drivers/video/fbdev/sis/sis_main.c
[]
quoted hunk
@@ -237,7 +237,7 @@ static void sisfb_get_vga_mode_from_kernel(void)
 
 		if(mydepth = 24) mydepth = 32;
 
-		sprintf(mymode, "%ux%ux%u", screen_info.lfb_width,
+		sprintf(mymode, "%ux%ux%d", screen_info.lfb_width,
 					screen_info.lfb_height,
 					mydepth);
 

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help