Re: [PATCH RFC 2/3] fbdev: move fbdev core files to separate directory

On 14/02/14 14:27, Geert Uytterhoeven wrote:

Hi Tomi,

Thanks for doing this!

Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>

On Fri, Feb 14, 2014 at 12:18 PM, Tomi Valkeinen [off-list ref] wrote:

quoted

--- a/drivers/video/fbdev/fbmon.c
+++ b/drivers/video/fbdev/core/fbmon.c

@@ -37,7 +37,7 @@
 #include <asm/prom.h>
 #include <asm/>
 /*
  * EDID parserpci-bridge.h>
 #endif
-#include "edid.h"
+#include "../edid.h"

This looks a bit asymmetrical ...

quoted

--- a/drivers/video/fbdev/wmt_ge_rops.c
+++ b/drivers/video/fbdev/wmt_ge_rops.c

@@ -18,7 +18,7 @@
 #include <linux/module.h>
 #include <linux/fb.h>
 #include <linux/platform_device.h>
-#include "fb_draw.h"
+#include "core/fb_draw.h"

... to this.

Perhaps (the content of) edid.h belongs in include/video/edid.h?

Yes, I thought the same, but I didn't want to start messing around too
much in this series. I also noticed some odd Kconfig options (for
example, HAVE_FB_ATMEL, SH_MIPI_DSI, SH_LCD_MIPI_DSI at the beginning of
drivers/video/Kconfig), which I almost started cleaning up, but decided
to just concentrate on the main reorganization.

 Tomi