Thread (4 messages) 4 messages, 3 authors, 2014-02-17

Re: [PATCH RFC 2/3] fbdev: move fbdev core files to separate directory

flat view

From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2014-02-14 12:27:15
Also in: dri-devel, lkml

Hi Tomi,

Thanks for doing this!

Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>

On Fri, Feb 14, 2014 at 12:18 PM, Tomi Valkeinen [off-list ref] wrote:
quoted hunk ↗ jump to hunk
--- a/drivers/video/fbdev/fbmon.c
+++ b/drivers/video/fbdev/core/fbmon.c
@@ -37,7 +37,7 @@
 #include <asm/prom.h>
 #include <asm/>
 /*
  * EDID parserpci-bridge.h>
 #endif
-#include "edid.h"
+#include "../edid.h"
This looks a bit asymmetrical ...
quoted hunk ↗ jump to hunk
--- a/drivers/video/fbdev/wmt_ge_rops.c
+++ b/drivers/video/fbdev/wmt_ge_rops.c
@@ -18,7 +18,7 @@
 #include <linux/module.h>
 #include <linux/fb.h>
 #include <linux/platform_device.h>
-#include "fb_draw.h"
+#include "core/fb_draw.h"
... to this.

Perhaps (the content of) edid.h belongs in include/video/edid.h?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help