Re: [PATCH] fbdev: fix error return code in metronomefb_probe()
flat view
From: Jean-Christophe PLAGNIOL-VILLARD <hidden>
Date: 2013-10-19 10:52:02
On 14:25 Sat 12 Oct , Wei Yongjun wrote:
From: Wei Yongjun <redacted> Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function.
Acked-by: Jean-Christophe PLAGNIOL-VILLARD <redacted> Tomi can you take it as a fix Best Regards, J.
quoted hunk ↗ jump to hunk
Signed-off-by: Wei Yongjun <redacted> --- drivers/video/metronomefb.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)diff --git a/drivers/video/metronomefb.c b/drivers/video/metronomefb.c index f30150d..0b36160 100644 --- a/drivers/video/metronomefb.c +++ b/drivers/video/metronomefb.c@@ -690,7 +690,8 @@ static int metronomefb_probe(struct platform_device *dev) goto err_csum_table; } - if (board->setup_irq(info)) + retval = board->setup_irq(info); + if (retval) goto err_csum_table; retval = metronome_init_regs(par);