[PATCH] fbdev: fix error return code in metronomefb_probe()

Subsystems: framebuffer layer, the rest

STALE4660d

3 messages, 3 authors, 2013-10-29 · open the first message on its own page

[PATCH] fbdev: fix error return code in metronomefb_probe()

From: Wei Yongjun <hidden>
Date: 2013-10-12 06:25:23

From: Wei Yongjun <redacted>

Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.

Signed-off-by: Wei Yongjun <redacted>
---
 drivers/video/metronomefb.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/video/metronomefb.c b/drivers/video/metronomefb.c
index f30150d..0b36160 100644
--- a/drivers/video/metronomefb.c
+++ b/drivers/video/metronomefb.c

@@ -690,7 +690,8 @@ static int metronomefb_probe(struct platform_device *dev)
 		goto err_csum_table;
 	}
 
-	if (board->setup_irq(info))
+	retval = board->setup_irq(info);
+	if (retval)
 		goto err_csum_table;
 
 	retval = metronome_init_regs(par);

Re: [PATCH] fbdev: fix error return code in metronomefb_probe()

From: Jean-Christophe PLAGNIOL-VILLARD <hidden>
Date: 2013-10-19 10:52:02

On 14:25 Sat 12 Oct     , Wei Yongjun wrote:

From: Wei Yongjun <redacted>

Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.

Acked-by: Jean-Christophe PLAGNIOL-VILLARD <redacted>

Tomi can you take it as a fix

Best Regards,
J.

quoted hunk

Signed-off-by: Wei Yongjun <redacted>
---
 drivers/video/metronomefb.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/video/metronomefb.c b/drivers/video/metronomefb.c
index f30150d..0b36160 100644
--- a/drivers/video/metronomefb.c
+++ b/drivers/video/metronomefb.c

@@ -690,7 +690,8 @@ static int metronomefb_probe(struct platform_device *dev)
 		goto err_csum_table;
 	}
 
-	if (board->setup_irq(info))
+	retval = board->setup_irq(info);
+	if (retval)
 		goto err_csum_table;
 
 	retval = metronome_init_regs(par);

Re: [PATCH] fbdev: fix error return code in metronomefb_probe()

From: Tomi Valkeinen <hidden>
Date: 2013-10-29 10:21:10

On 12/10/13 09:25, Wei Yongjun wrote:

quoted hunk

From: Wei Yongjun <redacted>

Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.

Signed-off-by: Wei Yongjun <redacted>
---
 drivers/video/metronomefb.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/video/metronomefb.c b/drivers/video/metronomefb.c
index f30150d..0b36160 100644
--- a/drivers/video/metronomefb.c
+++ b/drivers/video/metronomefb.c

@@ -690,7 +690,8 @@ static int metronomefb_probe(struct platform_device *dev)
 		goto err_csum_table;
 	}
 
-	if (board->setup_irq(info))
+	retval = board->setup_irq(info);
+	if (retval)
 		goto err_csum_table;
 
 	retval = metronome_init_regs(par);

Thanks, queued for 3.13.

 Tomi

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help