Thread (8 messages) flat view 8 messages, 5 authors, 2013-10-09

Re: [PATCH v2] simplefb: print some info about the registered fb

From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2013-09-07 13:55:40
Also in: lkml

On Sat, Sep 7, 2013 at 1:43 PM, Tom Gundersen [off-list ref] wrote:
+       dev_info(&pdev->dev, "framebuffer at 0x%lx, 0x%lx bytes, mapped to 0x%p\n",
+                            info->fix.smem_start, (unsigned long) info->fix.smem_len,
Please drop the cast, and use 0x%x. __u32 is unsigned int everywhere (where it
matters --- we don't do 16-bit ints).

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help